feat: add support for Kubernetes v1.19.0

[mboersma]

Reason for Change:

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#v1190

Issue Fixed:

Requirements:

• Kubernetes artifacts built and pushed by Azure Pipelines
• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

The official release is in progress, and then we will kick off the pipeline to build signed artifacts hosted with Azure. So this will fail testing for now. Edit: all done!

[codecov]

Codecov Report

Merging #3754 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3754   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files         148      148           
  Lines       25372    25372           
=======================================
  Hits        18573    18573           
  Misses       5663     5663           
  Partials     1136     1136           

Impacted Files	Coverage Δ
pkg/api/common/versions.go	96.84% <ø> (ø)
pkg/engine/templates_generated.go	53.42% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a57769...d4d9cc8. Read the comment docs.

[mboersma]

We can omit these conditionals if apiextensions.k8s.io/v1 was supported on Kubernetes 1.15. The v1beta1 version became deprecated with 1.19, but IDK when v1 first became supported.

[jackfrancis]

This calico spec will only be delivered in a Kubernetes v1.15 cluster creation context, do we need to do anything here?

[mboersma]

Oops...bad example. I reverted changes to this file, but there are many similar changes in other manifests.

[jackfrancis]

The changes to the apiextensions.k8s.io/v1beta1 apiVersion are breaking the secrets-store-csi spec. From kube-addon-manager logs:

error validating "/etc/kubernetes/addons/secrets-store-csi-driver.yaml": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "validation" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]; if you choose to ignore these errors, turn validation off with --validate=false

This seems to be complaining about these lines:

https://github.com/Azure/aks-engine/blob/master/parts/k8s/addons/secrets-store-csi-driver.yaml#L203
https://github.com/Azure/aks-engine/blob/master/parts/k8s/addons/secrets-store-csi-driver.yaml#L266

@chewong @aramase Do we need to undo the api version change and revert back to:

apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition

Or do we want to delete that version property from the spec using the new apiVersion: apiextensions.k8s.io/v1 declaration?

[aramase]

Do we need to undo the api version change and revert back to:

@jackfrancis Can we keep the version for now as apiextensions.k8s.io/v1beta1. I'll open a follow up PR later to update the api version after some testing upstream.

apiextensions.k8s.io/v1beta1 was deprecated in 1.19 and is planned for removal in 1.22 (kubernetes/kubernetes#82022). I'll setup some tests upstream to run with 1.19 before including that change in aks-engine. WDYT?

[jackfrancis]

@aramase Great plan, will do!

[jackfrancis]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment