fix: availabilityZones value in template to read from parameter

[manishram]

fix: Fix availabilityZones value in template to read from parameter

Reason for Change:
The availability zone of virtualMachineScaleSets is specified directly in the template file instead of reading from the parameter file.

Issue Fixed:
Fixes #3762

fix: Bug Fixes 🐞

Earlier:

Now:

[welcome]

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

[jackfrancis]

@manishram Thanks! can you get rid of the change in the vendor directory (may have been a local go mod artifact)?

[manishram]

@jackfrancis should I revert the change in line number 2488 and do that for line number 10636 or completely revert changes from that file?

[jackfrancis]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[manishram]

@jackfrancis why tests are failing? Any more changes I need to do?

[jackfrancis]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

Merging #3767 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3767      +/-   ##
==========================================
- Coverage   73.20%   73.19%   -0.01%     
==========================================
  Files         148      148              
  Lines       25372    25378       +6     
==========================================
+ Hits        18573    18576       +3     
- Misses       5663     5666       +3     
  Partials     1136     1136              

Impacted Files	Coverage Δ
pkg/engine/virtualmachinescalesets.go	79.96% <0.00%> (-0.41%)	⬇️
pkg/engine/templates_generated.go	53.42% <0.00%> (ø)
pkg/engine/template_generator.go	82.19% <0.00%> (+0.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e38aa8...5fe6e52. Read the comment docs.

[manishram]

@jackfrancis what is the cause for failing?

[jackfrancis]

/azp run pr-e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[manishram]

@jackfrancis still some problem with codecov

[jackfrancis]

@manishram don't worry about the codecov check, thanks for this contribution!

[jackfrancis]

/lgtm

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, manishram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment