Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: add doc and example api model for IPv6 #3777

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Sep 2, 2020

Reason for Change:

  • Adds example api model for IPv6 clusters
  • Adds docs for IPv6

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/L label Sep 2, 2020
@aramase aramase force-pushed the singlestack-ipv6 branch 2 times, most recently from 5e47b1b to 0113b9d Compare September 2, 2020 18:47
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #3777 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3777   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         148      148           
  Lines       25378    25378           
=======================================
  Hits        18576    18576           
  Misses       5666     5666           
  Partials     1136     1136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e4c3d...ff7ca3e. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Sep 2, 2020
@jackfrancis jackfrancis merged commit 9d26cb4 into Azure:master Sep 2, 2020
@acs-bot
Copy link

acs-bot commented Sep 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aramase aramase deleted the singlestack-ipv6 branch September 2, 2020 21:57
- IPv6 support is available for Kubernetes version 1.18.0 and later on Azure.
- IPv6 support is in beta as of Kubernetes version 1.18 in Kubernetes community.

In order to create IPv6 enabled Azure virtual networks and use standard loadbalancer with IPv6 you must first configure your subscription [as follows](https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-ipv4-ipv6-dual-stack-cli#prerequisites).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no #prerequisites paragraph on that page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also nit: as follows implies it's described below, should be as described [here](link)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is now GA, so they have removed the prerequisites. I'll update the doc to reflect that change.

penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants