chore: update node-problem-detector addon to v0.8.4

[mboersma]

Reason for Change:

See https://github.com/kubernetes/node-problem-detector/releases/tag/v0.8.4

Issue Fixed:

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

I've tested this locally by enabling the node-problem-detector addon and provisioning a 1.19.0 cluster.

[codecov]

Codecov Report

Merging #3779 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3779   +/-   ##
=======================================
  Coverage   73.19%   73.20%           
=======================================
  Files         148      148           
  Lines       25378    25384    +6     
=======================================
+ Hits        18576    18582    +6     
  Misses       5666     5666           
  Partials     1136     1136           

Impacted Files	Coverage Δ
pkg/api/k8s_versions.go	100.00% <ø> (ø)
pkg/api/addons.go	97.80% <100.00%> (ø)
pkg/engine/templates_generated.go	53.42% <0.00%> (ø)
pkg/engine/engine.go	85.74% <0.00%> (+0.10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e4c3d...f5d0f2d. Read the comment docs.

[jackfrancis]

Should we add the node-problem-detector addon to the "everything" test cluster config? And to the definition.json api model example that we run PR E2E against?

[mboersma]

Yes we should, because there's an e2e test that covers this functionality that is never activated otherwise. I'll make that update.

[mboersma]

STEP: Ensuring that the node-problem-detector pod(s) in the node-problem-detector addon is Running
antrea disabled for this cluster, will not test
flannel disabled for this cluster, will not test
scheduled-maintenance disabled for this cluster, will not test
STEP: Ensuring that the csi-secrets-store pod(s) in the csi-secrets-store addon is Running
STEP: Ensuring that the csi-secrets-store-provider-azure pod(s) in the csi-secrets-store addon is Running
• [SLOW TEST:221.067 seconds]
Azure Container Cluster using the Kubernetes Orchestrator
/__w/1/s/test/e2e/kubernetes/kubernetes_test.go:204
regardless of agent pool type
/__w/1/s/test/e2e/kubernetes/kubernetes_test.go:205
should have addon pods running
/__w/1/s/test/e2e/kubernetes/kubernetes_test.go:1025

Azure Container Cluster using the Kubernetes Orchestrator regardless of agent pool type
should have a working node-problem-detector configuration
/__w/1/s/test/e2e/kubernetes/kubernetes_test.go:1108
$ ssh -A -i /__w/1/s/_output/kubernetes-southeastasia-25968-ssh -p 22 -o ConnectTimeout=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=ERROR azureuser@kubernetes-southeastasia-25968.southeastasia.cloudapp.azure.com ssh -o ConnectTimeout=10 -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=ERROR k8s-pool1604-13096053-vmss000000 sudo 'echo kernel: BUG: unable to handle kernel NULL pointer dereference at TESTING-142661312433 | sudo tee /dev/kmsg'
•

Tests look good.

[jackfrancis]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment