This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: secrets store addon can pull from custom env #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3787 +/- ##
==========================================
+ Coverage 73.20% 73.21% +0.01%
==========================================
Files 148 148
Lines 25384 25385 +1
==========================================
+ Hits 18582 18586 +4
+ Misses 5666 5663 -3
Partials 1136 1136
Continue to review full report at Codecov.
|
jackfrancis
reviewed
Sep 3, 2020
jadarsie
changed the title
jadarsie
force-pushed
the
secret-store-custom-env
branch
2 times, most recently
from
de17d6d
to
a79d72c
Compare
jadarsie
force-pushed
the
secret-store-custom-env
branch
from
a79d72c
to
aa9508c
Compare
jadarsie
changed the title
jackfrancis
reviewed
Sep 8, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Make sure that the secrets store addon is able to pull Key Vault entries from air-gapped clouds.
Issue Fixed:
Fixes #3786
Requirements:
Notes: