Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: add keyVaultEndpoint to generated Azure Stack environment file #3790

Merged
merged 1 commit into from
Sep 5, 2020

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Sep 4, 2020

Reason for Change:

The secrets-store-csi-driver-provider-azure addon loads keyVaultEndpoint from azurestackcloud.json. This PR makes sure the required data is persisted in the nodes file system.

Requirements:

Notes:

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit db1bc06 into Azure:master Sep 5, 2020
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants