Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Azure Stack CNI network interfaces file creation fix #3792

Merged

Conversation

JesusAlvarezTorres
Copy link
Contributor

Reason for Change:

Fixing an issue seen in Azure Stack during the creation of the network interfaces file for the Azure CNI plugin

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added size/M and removed size/S labels Sep 8, 2020
jadarsie
jadarsie previously approved these changes Sep 9, 2020
@JesusAlvarezTorres JesusAlvarezTorres changed the title [WIP] fix: Azure Stack CNI network interfaces file creation fix fix: Azure Stack CNI network interfaces file creation fix Sep 9, 2020
jadarsie
jadarsie previously approved these changes Sep 10, 2020
jackfrancis
jackfrancis previously approved these changes Sep 11, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for linux fixes

@marosset and @jsturtevant to review the powershell additions

@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #3792 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   73.20%   73.20%   -0.01%     
==========================================
  Files         148      148              
  Lines       25384    25428      +44     
==========================================
+ Hits        18582    18614      +32     
- Misses       5666     5679      +13     
+ Partials     1136     1135       -1     
Impacted Files Coverage Δ
pkg/engine/cse.go 100.00% <ø> (ø)
pkg/engine/templates_generated.go 52.91% <ø> (-0.51%) ⬇️
cmd/upgrade.go 42.71% <0.00%> (-1.50%) ⬇️
pkg/engine/armvariables.go 86.44% <0.00%> (-0.06%) ⬇️
pkg/api/common/const.go 40.00% <0.00%> (ø)
pkg/api/k8s_versions.go 100.00% <0.00%> (ø)
pkg/api/common/versions.go 96.84% <0.00%> (ø)
pkg/api/defaults-kubelet.go 96.82% <0.00%> (+0.01%) ⬆️
pkg/engine/artifacts.go 99.15% <0.00%> (+0.01%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf9c0f...2c92346. Read the comment docs.

@jackfrancis
Copy link
Member

ping again @marosset @jsturtevant

@JesusAlvarezTorres
Copy link
Contributor Author

/azp run pr-e2e

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 3792 in repo Azure/aks-engine

@jsturtevant
Copy link
Contributor

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marosset
Copy link
Contributor

/lgtm

@acs-bot acs-bot added the lgtm label Sep 16, 2020
@jackfrancis jackfrancis merged commit 77fb788 into Azure:master Sep 16, 2020
@acs-bot
Copy link

acs-bot commented Sep 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JesusAlvarezTorres, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants