Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: mark rotate-certs command as experimental #3869

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR marks the rotate-certs functionality as experimental, as recent tests suggest it's not in a working state.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

cc @jadarsie

@acs-bot
Copy link

acs-bot commented Sep 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3869 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3869   +/-   ##
=======================================
  Coverage   72.83%   72.83%           
=======================================
  Files         149      149           
  Lines       23171    23171           
=======================================
  Hits        16876    16876           
  Misses       5178     5178           
  Partials     1117     1117           
Impacted Files Coverage Δ
cmd/rotate_certs.go 64.06% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3556e...3bf2a79. Read the comment docs.

@jackfrancis jackfrancis merged commit 190444d into Azure:master Sep 25, 2020
@jackfrancis jackfrancis deleted the rotate-certs-experimental branch September 25, 2020 16:31
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants