Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: remove NSG rules for AzureStack #3914

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

haofan-ms
Copy link
Contributor

@haofan-ms haofan-ms commented Oct 9, 2020

Reason for Change:

These NSG rules were added specifically for Azure Stack regarding a previous bug. Now the bug on Azure Stack has been fixed, these NSG rules can be removed.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #3914 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3914      +/-   ##
==========================================
- Coverage   72.85%   72.82%   -0.04%     
==========================================
  Files         149      149              
  Lines       23220    23191      -29     
==========================================
- Hits        16917    16888      -29     
  Misses       5182     5182              
  Partials     1121     1121              
Impacted Files Coverage Δ
pkg/engine/networksecuritygroups.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4fffc...e8e5d96. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Oct 9, 2020
@jackfrancis jackfrancis merged commit 17da6d7 into Azure:master Oct 9, 2020
@acs-bot
Copy link

acs-bot commented Oct 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haofan-ms, honcao, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants