This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: custom Windows log collection script #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jadarsie feel free to merge this if it meets w/ your review approval |
jadarsie
suggested changes
Oct 16, 2020
There was a problem hiding this comment.
Please check if this page needs to be updated: https://github.com/Azure/aks-engine/blob/master/docs/topics/get-logs.md
Updated documentation, thanks. |
jadarsie
suggested changes
Oct 21, 2020
jadarsie
suggested changes
Oct 23, 2020
jadarsie
approved these changes
Oct 26, 2020
jadarsie
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haofan-ms, jadarsie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
penggu
pushed a commit
to penggu/aks-engine
that referenced
this pull request
Oct 28, 2020
* feat: custom Windows log collection script * update * update code logic * address comments * remove unused * fix linting * address comments * revert versions * add tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: