Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes v1.18.10 on Azure Stack #3950

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

JesusAlvarezTorres
Copy link
Contributor

Reason for Change:

Change adds support for Kubernetes v1.18.10 on Azure Stack

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@JesusAlvarezTorres
Copy link
Contributor Author

/assign @mboersma

@jadarsie
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackfrancis
Copy link
Member

@JesusAlvarezTorres if you rebase this on top of current master we should be able to re-run CI and get accurate Windows VHD signal

@JesusAlvarezTorres
Copy link
Contributor Author

@JesusAlvarezTorres if you rebase this on top of current master we should be able to re-run CI and get accurate Windows VHD signal

thanks for the heads up @jackfrancis , rebased.

@JesusAlvarezTorres
Copy link
Contributor Author

JesusAlvarezTorres commented Oct 28, 2020

@jackfrancis FYI my build vhd pipeline failed, the problem seems to be the 1.18.8 images have been removed. That change is in #3948. I therefore need that PR to go first, then rebase, then this PR can be validated and go in.

@jackfrancis
Copy link
Member

@JesusAlvarezTorres one more rebase and we can get this in :)

@JesusAlvarezTorres
Copy link
Contributor Author

@JesusAlvarezTorres one more rebase and we can get this in :)

thanks @jackfrancis just pushed the rebase

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Oct 29, 2020
@jackfrancis jackfrancis merged commit ca2f7a6 into Azure:master Oct 29, 2020
@acs-bot
Copy link

acs-bot commented Oct 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, JesusAlvarezTorres

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants