Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: resource identifier not pass to custom cloud profile #3953

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Oct 21, 2020

Reason for Change:
Bug fix
Generated custom cloud profile does not contain resource identifiers even when set in API model.
It may cause unexpected application behavior for those programs relying on these values

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@welcome
Copy link

welcome bot commented Oct 21, 2020

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/L label Oct 21, 2020
@mboersma
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jadarsie
Copy link
Member

jadarsie commented Oct 21, 2020

lgtm

A simple deployment worked on ASH

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Oct 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, laozc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jadarsie jadarsie merged commit 44bae54 into Azure:master Oct 26, 2020
@welcome
Copy link

welcome bot commented Oct 26, 2020

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants