Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: ensure flatcar configs use transparent Azure CNI #3972

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Oct 26, 2020

Reason for Change:

This PR ensures that new flatcar node pool-enabled clusters use transparent mode if using Azure CNI, as that's proven to be the only working Azure CNI implementation w/ flatcar.

No upgrade foo added here; we'll see if folks desire that, but for now, this is a cleaner change that doesn't try to be too tricky in "converting" existing clusters that were built w/ bridge mode prior to the systemd change that broke it.

Fixes #3920

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Oct 26, 2020
@acs-bot
Copy link

acs-bot commented Oct 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit e7a5680 into Azure:master Oct 27, 2020
@jackfrancis jackfrancis deleted the flatcar-azure-cni-transparent branch October 27, 2020 16:35
penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatcar nodes don't work w/ Azure CNI + bridge mode
2 participants