Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: Jenkinsfile bool vars #3980

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR ensures that various entry points into cluster.sh's make test kubernetes invocation set a bool value to VALIDATE_CPU_LOAD, to avoid errors like this:

Error while trying to parse configuration: envconfig.Process: assigning CONFIG_VALIDATE_CPU_LOAD to ValidateCPULoad: converting '' to type bool. details: strconv.ParseBool: parsing "": invalid syntax

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis jackfrancis changed the title Jenkinsfile bool vars test: Jenkinsfile bool vars Oct 28, 2020
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Oct 28, 2020
@jackfrancis jackfrancis merged commit 2780dca into Azure:master Oct 28, 2020
@acs-bot
Copy link

acs-bot commented Oct 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

penggu pushed a commit to penggu/aks-engine that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants