This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: move ssh-related funcs to its own package #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadarsie
commented
Oct 30, 2020
| @@ -52,3 +52,9 @@ type Client interface { | |||
| // UpdateDeployment updates a deployment to match the given specification. | |||
| UpdateDeployment(namespace string, deployment *appsv1.Deployment) (*appsv1.Deployment, error) | |||
| } | |||
|
|
|||
| // NodeLister is an interface implemented by Kubernetes clients | |||
There was a problem hiding this comment.
part of the kubernetes package just for consistency, an alternative is to move it to package cmd
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, jadarsie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Increasing test coverage of
get_logs.goand removing some code duplication noticed while working onrotate-certs.Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes: