Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: fix two UTs to work with "cli" auth #3995

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Nov 2, 2020

Reason for Change:

Locally we've noticed two test cases may fail. This seems to be because there are no required arguments to the get-locations and get-skus commands if cli auth is working.

To meet test expectations, I explicitly added a bogus command-line argument to ensure these tests see an expected error in any case.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #3995 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3995      +/-   ##
==========================================
- Coverage   73.83%   73.68%   -0.16%     
==========================================
  Files         147      147              
  Lines       23161    23161              
==========================================
- Hits        17102    17067      -35     
- Misses       4942     4979      +37     
+ Partials     1117     1115       -2     
Impacted Files Coverage Δ
cmd/root.go 57.52% <0.00%> (-12.37%) ⬇️
cmd/get_skus.go 46.51% <0.00%> (-11.63%) ⬇️
cmd/get_locations.go 86.57% <0.00%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ce365...858ed6b. Read the comment docs.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit def9ecb into Azure:master Nov 2, 2020
@mboersma mboersma deleted the fix-get-mumble-tests branch November 2, 2020 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants