Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update cluster-autoscalers to latest patches #4000

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Nov 3, 2020

Reason for Change:

See https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.18.3
and https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.17.4
and https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.16.7
and #3996

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@mboersma
Copy link
Member Author

mboersma commented Nov 3, 2020

/hold

This has a temporary testing commit that needs to be discarded before merging.

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #4000 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4000   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files         147      147           
  Lines       23161    23161           
=======================================
  Hits        17067    17067           
  Misses       4979     4979           
  Partials     1115     1115           
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4262e4b...c5204b9. Read the comment docs.

@mboersma
Copy link
Member Author

mboersma commented Nov 3, 2020

/azp run AKS Engine VHD Pipeline

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mboersma
Copy link
Member Author

mboersma commented Nov 4, 2020

New autoscalers passed our CI for 1.16 to 1.18:

image

I'll strip off the testing commit and then this should be ready for review.

@mboersma
Copy link
Member Author

mboersma commented Nov 4, 2020

/hold cancel

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit f15233a into Azure:master Nov 4, 2020
@mboersma mboersma deleted the ca-bumps-again branch November 4, 2020 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants