Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: Adding CI pipeline to verify windows provisioning script content BEFORE it gets check in #4008

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Nov 5, 2020

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Nov 5, 2020
@marosset
Copy link
Contributor Author

marosset commented Nov 5, 2020

I have an azure devops job running on my fork for validation.
Once this merges I'll create a new devops job that triggers when anything in the staging folder is touched

@jsturtevant
Copy link
Contributor

/lgtm

Addresses #4003

@acs-bot
Copy link

acs-bot commented Nov 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #4008 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4008   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         147      147           
  Lines       23164    23164           
=======================================
  Hits        17070    17070           
  Misses       4979     4979           
  Partials     1115     1115           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2dfd7...e869443. Read the comment docs.

@marosset marosset merged commit d36d436 into Azure:master Nov 5, 2020
@marosset marosset deleted the windows-signed-scripts-ci branch November 5, 2020 21:13
jackfrancis pushed a commit that referenced this pull request Nov 13, 2020
…BEFORE it gets check in (#4008)

* Adding CI pipeline to verify windows provisioning script content BEFORE it gets checked in.

* updating conditions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants