Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: remove node-problem-detector addon from PR E2E #4010

Merged

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Nov 5, 2020

Reason for Change:

So that Azure cloud-init is happy!

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/XS label Nov 5, 2020
@jackfrancis
Copy link
Member Author

cc @mboersma

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Assuming CI agrees, of course.

@acs-bot
Copy link

acs-bot commented Nov 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #4010 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4010   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         147      147           
  Lines       23164    23164           
=======================================
  Hits        17070    17070           
  Misses       4979     4979           
  Partials     1115     1115           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36d436...efa0694. Read the comment docs.

@jackfrancis jackfrancis merged commit 010fd9c into Azure:master Nov 5, 2020
@jackfrancis jackfrancis deleted the e2e-pr-rm-node-problem-detector branch November 5, 2020 23:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants