Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: enable dhcpv6 only for ubuntu 16.04 #4017

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Conversation

aramase
Copy link
Member

@aramase aramase commented Nov 7, 2020

Reason for Change:

  • dhcpv6 systemd unit is only required for ubuntu 16.04

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #4017 (3492e5a) into master (c309c3f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4017   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         147      147           
  Lines       23164    23164           
=======================================
  Hits        17070    17070           
  Misses       4979     4979           
  Partials     1115     1115           
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.97% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c309c3f...3492e5a. Read the comment docs.

@aramase
Copy link
Member Author

aramase commented Nov 9, 2020

@jackfrancis What are your thoughts on enabling dualstack api model for e2e tests? The e2e test suite should work as is for dualstack. Once dualstack is beta in k/k we can add dualstack specific tests to the e2e suite.

@jackfrancis
Copy link
Member

@jackfrancis What are your thoughts on enabling dualstack api model for e2e tests? The e2e test suite should work as is for dualstack. Once dualstack is beta in k/k we can add dualstack specific tests to the e2e suite.

Good idea. Should we add a config to the test/e2e/test_cluster_configs/ directory that looks something like examples/dualstack/kubernetes.json? FYI the JSON config is a bit different for the jenkins configs under test/e2e/test_cluster_configs/ (the actual API model goes into a "apiModel"` object, for example).

@aramase
Copy link
Member Author

aramase commented Nov 9, 2020

Good idea. Should we add a config to the test/e2e/test_cluster_configs/ directory that looks something like examples/dualstack/kubernetes.json? FYI the JSON config is a bit different for the jenkins configs under test/e2e/test_cluster_configs/ (the actual API model goes into a "apiModel"` object, for example).

I'm going to update the examples/dualstack/kubernetes.json to use 1.20 when it's available because dualstack services has been reimplemented in 1.20. The current config we use for testing is https://github.com/aramase/manifests/blob/main/dualstack/iptables-kubenet.json.

Let me add to test/e2e/test_cluster_configs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants