-
Notifications
You must be signed in to change notification settings - Fork 527
fix: enable dhcpv6 only for ubuntu 16.04 #4017
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4017 +/- ##
=======================================
Coverage 73.69% 73.69%
=======================================
Files 147 147
Lines 23164 23164
=======================================
Hits 17070 17070
Misses 4979 4979
Partials 1115 1115
Continue to review full report at Codecov.
|
@jackfrancis What are your thoughts on enabling dualstack api model for e2e tests? The e2e test suite should work as is for dualstack. Once dualstack is beta in k/k we can add dualstack specific tests to the e2e suite. |
Good idea. Should we add a config to the |
I'm going to update the Let me add to |
472f98b
to
1937e21
Compare
3495d85
to
f19edf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aramase, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
16.04
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: