Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: Adding csi-proxy logs locked file list to prevent access denied errors #4029

Merged

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Nov 12, 2020

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@marosset
Copy link
Contributor Author

/assign @jsturtevant @chewong

@marosset
Copy link
Contributor Author

This is to address this issue
kubernetes/kubernetes#93948 (comment)

Copy link

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Nov 12, 2020
@marosset marosset changed the title fix: Adding csi-proxy logs to prevent access denied errors fix: Adding csi-proxy logs locked file list to prevent access denied errors Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #4029 (6072f40) into master (bad4467) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4029      +/-   ##
==========================================
+ Coverage   73.69%   73.72%   +0.03%     
==========================================
  Files         147      147              
  Lines       23164    23177      +13     
==========================================
+ Hits        17070    17087      +17     
+ Misses       4979     4976       -3     
+ Partials     1115     1114       -1     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 48.97% <0.00%> (ø)
...g/operations/kubernetesupgrade/upgradeagentnode.go 47.88% <0.00%> (ø)
.../operations/kubernetesupgrade/upgrademasternode.go 42.55% <0.00%> (ø)
pkg/engine/transform/transform.go 71.76% <0.00%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad4467...6072f40. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jackfrancis jackfrancis merged commit 2a214b2 into Azure:master Nov 13, 2020
@acs-bot
Copy link

acs-bot commented Nov 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jackfrancis, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants