Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: deprecate orchestratorType #4038

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

With #4036 merging, we no longer nominally support any non-Kubernetes orchestrators in any code flows (馃帀). This change means that the orchestratorType property has no semantic value.

This PR effectively "deprecates" the orchestratorType property in the orchestratorProfile configuration object:

  • defaults to Kubernetes where appropriate, so that it no longer needs to be included in API model definitions
  • removes several validations whose purpose was to ensure that "orchestratorType == Kubernetes"; because that is always true, those validations are superfluous
  • updated documentation and example API models

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #4038 (a85cbba) into master (f5bdb8b) will increase coverage by 0.01%.
The diff coverage is 72.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
+ Coverage   73.06%   73.08%   +0.01%     
==========================================
  Files         145      145              
  Lines       21856    21776      -80     
==========================================
- Hits        15969    15914      -55     
+ Misses       4849     4829      -20     
+ Partials     1038     1033       -5     
Impacted Files Coverage 螖
cmd/addpool.go 18.18% <0.00%> (+0.10%) 猬嗭笍
cmd/scale.go 12.70% <0.00%> (+0.06%) 猬嗭笍
pkg/api/common/versions.go 96.37% <0.00%> (-1.01%) 猬囷笍
pkg/api/convertertoagentpoolonlyapi.go 89.47% <酶> (+0.93%) 猬嗭笍
pkg/engine/template_generator.go 67.44% <0.00%> (-0.16%) 猬囷笍
pkg/engine/templates_generated.go 43.70% <酶> (酶)
pkg/engine/output.go 35.38% <22.50%> (-0.98%) 猬囷笍
pkg/api/vlabs/validate.go 81.60% <78.41%> (+0.37%) 猬嗭笍
pkg/engine/params_k8s.go 85.13% <84.93%> (-0.10%) 猬囷笍
pkg/api/apiloader.go 61.41% <100.00%> (+0.42%) 猬嗭笍
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f5bdb8b...a85cbba. Read the comment docs.

pkg/api/defaults.go Show resolved Hide resolved
pkg/api/defaults_test.go Show resolved Hide resolved
examples/kubernetes-kubenet-containerd.json Show resolved Hide resolved
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants