-
Notifications
You must be signed in to change notification settings - Fork 527
chore: deprecate orchestratorType #4038
chore: deprecate orchestratorType #4038
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4038 +/- ##
==========================================
+ Coverage 73.06% 73.08% +0.01%
==========================================
Files 145 145
Lines 21856 21776 -80
==========================================
- Hits 15969 15914 -55
+ Misses 4849 4829 -20
+ Partials 1038 1033 -5
Continue to review full report at Codecov.
|
d9b56ab
to
a85cbba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
With #4036 merging, we no longer nominally support any non-Kubernetes orchestrators in any code flows (馃帀). This change means that the
orchestratorType
property has no semantic value.This PR effectively "deprecates" the
orchestratorType
property in theorchestratorProfile
configuration object:Kubernetes
where appropriate, so that it no longer needs to be included in API model definitionsIssue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: