Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes 1.18.12 #4043

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

mboersma
Copy link
Member

Reason for Change:

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.18.md#changelog-since-v11811

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4043 (c0d3856) into master (5dbff4c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4043   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files         145      145           
  Lines       21776    21776           
=======================================
  Hits        15914    15914           
  Misses       4829     4829           
  Partials     1033     1033           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dbff4c...c0d3856. Read the comment docs.

@@ -211,6 +211,8 @@ var AllKubernetesSupportedVersions = map[string]bool{
"1.18.8": false,
"1.18.9": true,
"1.18.10": true,
"1.18.11": false, // replaced by 1.18.12 due to k8s release engineering issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this bit of comment accounting!

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Nov 18, 2020
@jackfrancis jackfrancis merged commit 0c80a28 into Azure:master Nov 18, 2020
@acs-bot
Copy link

acs-bot commented Nov 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the add-k8s-1.18.12 branch March 1, 2023 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants