Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: mark Kubernetes 1.17.14 as disabled #4044

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Nov 17, 2020

Reason for Change:

We saw test failures with 1.17.14 and have a fix for the next patch release at kubernetes/kubernetes#96623.

See also https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.17.md#changelog-since-v11713

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

  • Kubernetes artifacts built and pushed by Azure Pipelines
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

This PR contains a temporary testing commit that should be discarded before merging.

The Azure Pipeline for the 1.17.14 build has not completed successfully yet, so the artifacts are not published.

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4044 (bf75195) into master (fba3821) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4044      +/-   ##
==========================================
- Coverage   73.25%   73.25%   -0.01%     
==========================================
  Files         135      135              
  Lines       20641    20541     -100     
==========================================
- Hits        15121    15047      -74     
+ Misses       4544     4521      -23     
+ Partials      976      973       -3     
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/types.go 92.16% <0.00%> (-1.17%) ⬇️
pkg/api/mocks.go 100.00% <0.00%> (ø)
pkg/engine/templates_generated.go 43.70% <0.00%> (ø)
pkg/engine/engine.go 86.77% <0.00%> (+0.01%) ⬆️
pkg/api/vlabs/types.go 72.85% <0.00%> (+0.32%) ⬆️
pkg/engine/template_generator.go 67.55% <0.00%> (+0.73%) ⬆️
pkg/engine/virtualmachinescalesets.go 80.72% <0.00%> (+1.28%) ⬆️
pkg/engine/virtualmachines.go 82.79% <0.00%> (+1.73%) ⬆️
pkg/armhelpers/support_validator.go 61.11% <0.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba3821...bf75195. Read the comment docs.

@acs-bot acs-bot added size/XS and removed size/M labels Nov 20, 2020
@mboersma mboersma changed the title feat: add support for Kubernetes v1.17.14 chore: mark Kubernetes 1.17.4 as disabled Nov 20, 2020
@mboersma
Copy link
Member Author

/hold cancel

@mboersma mboersma changed the title chore: mark Kubernetes 1.17.4 as disabled chore: mark Kubernetes 1.17.14 as disabled Nov 20, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot acs-bot added the lgtm label Nov 20, 2020
@jackfrancis jackfrancis merged commit f11bfab into Azure:master Nov 20, 2020
@acs-bot
Copy link

acs-bot commented Nov 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the add-k8s-1.17.14 branch November 20, 2020 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants