Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Updating default csi-proxy version to v0.2.2 #4047

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Nov 18, 2020

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@marosset marosset changed the title Updating default csi-proxy version to v0.2.2 chore: Updating default csi-proxy version to v0.2.2 Nov 18, 2020
@jackfrancis
Copy link
Member

I think gofmt will get rid of lint errors

@marosset
Copy link
Contributor Author

I think gofmt will get rid of lint errors

I ran make test locally but not make test-style :'(

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #4047 (a8fb9cc) into master (71de031) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4047   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         135      135           
  Lines       20640    20640           
=======================================
  Hits        15113    15113           
  Misses       4550     4550           
  Partials      977      977           
Impacted Files Coverage Δ
pkg/api/common/versions.go 96.37% <0.00%> (ø)
pkg/engine/templates_generated.go 43.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71de031...a8fb9cc. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 29c2508 into Azure:master Nov 18, 2020
@marosset marosset deleted the csi-proxy-update-v0.2.2 branch January 8, 2021 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants