Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: only warn about master stuff during create #4057

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR removes MasterProfile warnings for update/scale/upgrade.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot acs-bot added the size/S label Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #4057 (e492716) into master (6db78a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4057   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files         135      135           
  Lines       20640    20641    +1     
=======================================
+ Hits        15115    15116    +1     
  Misses       4549     4549           
  Partials      976      976           
Impacted Files Coverage Δ
pkg/api/vlabs/validate.go 81.81% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d44bcd...e492716. Read the comment docs.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Nov 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit fba3821 into Azure:master Nov 20, 2020
@jackfrancis jackfrancis deleted the validate-warn-create-only branch November 20, 2020 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants