Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

test: disable useManagedIdentity default value on Azure Stack #4063

Merged
merged 5 commits into from
Dec 1, 2020

Conversation

haofan-ms
Copy link
Contributor

@haofan-ms haofan-ms commented Nov 25, 2020

Reason for Change:

The default true value of useManagedIdentity adds additional unsupported KubernetesConfig to Azure Stack API model, this is causing failure of Azure Stack E2E runs.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@haofan-ms haofan-ms changed the title test: set default useManagedIdentity value to "false" [WIP] test: set default useManagedIdentity value to "false" Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #4063 (bfcd9e0) into master (254f95f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4063   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         135      135           
  Lines       20555    20555           
=======================================
  Hits        15046    15046           
  Misses       4539     4539           
  Partials      970      970           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254f95f...bfcd9e0. Read the comment docs.

@haofan-ms haofan-ms changed the title [WIP] test: set default useManagedIdentity value to "false" test: disable useManagedIdentity default value on Azure Stack Dec 1, 2020
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jadarsie jadarsie merged commit 09928e7 into Azure:master Dec 1, 2020
@haofan-ms haofan-ms deleted the update-default-msi branch February 16, 2022 04:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants