This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: cleanup VMSSName + addpool #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
commented
Nov 30, 2020
| numExistingPools := len(apc.containerService.Properties.AgentPoolProfiles) | ||
| // we can reuse the value of numExistingPools due to array index beginning at "0" | ||
| apc.nodePool.VMSSName = apc.containerService.Properties.GetAgentVMPrefix(apc.nodePool, numExistingPools) | ||
| if apc.nodePool.VMSSName == "" { |
There was a problem hiding this comment.
We don't know what to do if we aren't able to generate a VMSSName, so we'll error out
Codecov Report
@@ Coverage Diff @@
## master #4067 +/- ##
=======================================
Coverage 73.25% 73.26%
=======================================
Files 135 135
Lines 20542 20539 -3
=======================================
- Hits 15048 15047 -1
Misses 4521 4521
+ Partials 973 971 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR cleans up some things from #4051, specifically:
aks-engine addpoolaks-engine addpoolIssue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: