Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add the aksEngineVersion tag #413

Merged
merged 2 commits into from Feb 1, 2019
Merged

feat: add the aksEngineVersion tag #413

merged 2 commits into from Feb 1, 2019

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Jan 31, 2019

Reason for Change:

VMSS agent VMs are missing the "aksEngineVersion" : "[parameters('aksEngineVersion')]", tag that VMAS VMs have (https://github.com/Azure/aks-engine/blob/master/parts/k8s/kubernetesmasterresourcesvmss.t#L415-L416).

Issue Fixed:

Fixes #411

Requirements:

Notes:

@tariq1890
Copy link
Contributor

@CecileRobertMichon @jackfrancis Thoughts on this PR? I am mostly okay with it, but don't have strong opinions given that we already tag the master VMs.

Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferring to others for final approval.

@CecileRobertMichon
Copy link
Contributor

@tariq1890 see #411 for context. Mathieu noticed the tag was missing on AKS VMSS preview VMs.

Thanks @mathieu-benoit for opening the PR!

/lgtm

@CecileRobertMichon
Copy link
Contributor

updated description

@acs-bot
Copy link

acs-bot commented Jan 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mathieu-benoit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   53.42%   53.42%           
=======================================
  Files          95       95           
  Lines       14363    14363           
=======================================
  Hits         7673     7673           
  Misses       6027     6027           
  Partials      663      663

@CecileRobertMichon CecileRobertMichon merged commit dcbc709 into Azure:master Feb 1, 2019
@welcome
Copy link

welcome bot commented Feb 1, 2019

Congrats on merging your first pull request! 🎉🎉🎉

tariq1890 pushed a commit to tariq1890/aks-engine that referenced this pull request Feb 1, 2019
@mathieu-benoit mathieu-benoit deleted the patch-2 branch February 1, 2019 15:37
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add AKSEngineVersion tag in agent VMSS templates
4 participants