Conversation
@CecileRobertMichon @jackfrancis Thoughts on this PR? I am mostly okay with it, but don't have strong opinions given that we already tag the master VMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferring to others for final approval.
@tariq1890 see #411 for context. Mathieu noticed the tag was missing on AKS VMSS preview VMs. Thanks @mathieu-benoit for opening the PR! /lgtm |
updated description |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mathieu-benoit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
=======================================
Coverage 53.42% 53.42%
=======================================
Files 95 95
Lines 14363 14363
=======================================
Hits 7673 7673
Misses 6027 6027
Partials 663 663 |
Congrats on merging your first pull request! 🎉🎉🎉 |
Reason for Change:
VMSS agent VMs are missing the "aksEngineVersion" : "[parameters('aksEngineVersion')]", tag that VMAS VMs have (https://github.com/Azure/aks-engine/blob/master/parts/k8s/kubernetesmasterresourcesvmss.t#L415-L416).
Issue Fixed:
Fixes #411
Requirements:
Notes: