Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

docs: add dual-stack iptables api model #4185

Merged
merged 1 commit into from Jan 22, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 22, 2021

Reason for Change:

  • Adds iptables api model for dual-stack
  • Updates dual-stack docs

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:
/cc @lachie83

@acs-bot
Copy link

acs-bot commented Jan 22, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aramase
To complete the pull request process, please assign ksubrmnn
You can assign the PR to them by writing /assign @ksubrmnn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member

Any changes we should make to the api model that we run tests against?

See test/e2e/test_cluster_configs/dualstack.json

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #4185 (70162cd) into master (1cd06c6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4185   +/-   ##
=======================================
  Coverage   73.38%   73.38%           
=======================================
  Files         135      135           
  Lines       20804    20804           
=======================================
  Hits        15267    15267           
  Misses       4562     4562           
  Partials      975      975           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362c62f...70162cd. Read the comment docs.

@aramase
Copy link
Member Author

aramase commented Jan 22, 2021

@jackfrancis No changes in the test cluster config. I'm adding the same model with iptables to the examples/dualstack dir.

@jackfrancis jackfrancis merged commit a53a0cc into Azure:master Jan 22, 2021
@aramase aramase deleted the add-dualstack-ipvs branch January 22, 2021 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants