This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: add support for Kubernetes v1.17.17 on Azure Stack #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JesusAlvarezTorres The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
code lgtm to @jadarsie for final review/merge |
jadarsie
reviewed
Jan 25, 2021
pkg/api/common/versions.go
Outdated
| @@ -269,6 +269,7 @@ var AllKubernetesSupportedVersionsAzureStack = map[string]bool{ | |||
| "1.17.7": false, | |||
| "1.17.9": true, | |||
| "1.17.11": true, | |||
There was a problem hiding this comment.
FYI, the linux VHD is not pre-pulling v1.17.11, not sure we want to keep both v1.17.11 and v1.17.17
There was a problem hiding this comment.
Good catch, I did not notice it, will submit a commit to remove v1.17.11
JesusAlvarezTorres
force-pushed
the
azs-k8s-1.17.17
branch
from
99f5931
to
7b8f047
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding support for Kubernetes v1.17.17 on Azure Stack
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: