This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: update nodecustomdata to enable portmapper for kubenet+containerd #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriksywu
force-pushed
the
erw/enable_portmapper_kubenet_containerd
branch
from
a2c9535
to
d36b3f5
Compare
eriksywu
changed the title
…/enable_portmapper_kubenet_containerd
|
/assign @jackfrancis |
|
/azp run pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## master #4191 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 135 135
Lines 20849 20849
=======================================
Hits 15308 15308
Misses 4566 4566
Partials 975 975
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eriksywu, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
AKS-Engine clusters on containerd + kubenet currently do not support hostPort mapping to a podSpec's containerPort
Issue Fixed:
See: Azure/AKS#2070
We confirmed this issue also applies to AKS-Engine clusters
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: