Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: reworked rotate-certs command #4214

Merged
merged 3 commits into from Feb 3, 2021

Conversation

jadarsie
Copy link
Member

@jadarsie jadarsie commented Feb 1, 2021

Reason for Change:

This PR tries to resurrect aks-engine rotate-certs.

Notes:

  • Breaking change: a few parameters renamed for consistency with get-logs

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #4214 (83fb304) into master (908ad43) will decrease coverage by 1.30%.
The diff coverage is 49.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4214      +/-   ##
==========================================
- Coverage   73.36%   72.06%   -1.31%     
==========================================
  Files         135      141       +6     
  Lines       20849    21690     +841     
==========================================
+ Hits        15296    15631     +335     
- Misses       4576     5102     +526     
+ Partials      977      957      -20     
Impacted Files Coverage Δ
cmd/rotatecerts/arm.go 0.00% <0.00%> (ø)
pkg/armhelpers/azurestack/compute.go 29.41% <0.00%> (-2.17%) ⬇️
pkg/armhelpers/compute.go 24.35% <0.00%> (-4.43%) ⬇️
pkg/armhelpers/mockclients.go 24.06% <0.00%> (-0.11%) ⬇️
pkg/engine/templates_generated.go 43.42% <0.00%> (-0.77%) ⬇️
pkg/kubernetes/client.go 0.00% <0.00%> (ø)
cmd/rotate_certs.go 11.62% <10.44%> (-52.45%) ⬇️
cmd/root.go 56.28% <38.46%> (-1.25%) ⬇️
pkg/api/apiloader.go 71.42% <60.00%> (-1.42%) ⬇️
cmd/rotatecerts/wait.go 72.18% <72.18%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908ad43...83fb304. Read the comment docs.

Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pending E2E signal

@acs-bot
Copy link

acs-bot commented Feb 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jadarsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,jadarsie]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit eaf2988 into Azure:master Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants