Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: per-agent pool k8s versions and provisioning state #423

Merged
merged 2 commits into from Feb 4, 2019

Conversation

kkmsft
Copy link
Contributor

@kkmsft kkmsft commented Feb 1, 2019

  • Add per agentpool level kubernetes version and provisioning state.
  • Add calls to delete an entire vmss.

Reason for Change:

Required work towards multi agentpool operations.

Issue Fixed:

These will start getting used by AKS multi agent pool work initially and then used in aks-engine multi agentpool operations - like delete, scale, upgrade.

Requirements:

Notes:

@welcome
Copy link

welcome bot commented Feb 1, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS-Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@CecileRobertMichon
Copy link
Contributor

⚠️ PR does not follow commit message convention ⚠️

pkg/armhelpers/compute.go Outdated Show resolved Hide resolved
pkg/api/types.go Outdated Show resolved Hide resolved
…e calls.

- Add per agentpool level kubernetes version and provisioning state.
- Add calls to delete an entire vmss.
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #423 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   53.41%   53.39%   -0.03%     
==========================================
  Files          95       95              
  Lines       14360    14433      +73     
==========================================
+ Hits         7670     7706      +36     
- Misses       6027     6061      +34     
- Partials      663      666       +3

- Change to OrchestratorVersion from KubernetesVersion as per review comments.
- Add couple of UTs.
@acs-bot acs-bot added size/M and removed size/S labels Feb 1, 2019
@jackfrancis jackfrancis added this to In progress in backlog Feb 1, 2019
@jackfrancis jackfrancis changed the title Agentpool level k8s version and provisioning, VMSS delete calls chore: per-agent pool k8s versions and provisioning state Feb 2, 2019
@jackfrancis
Copy link
Member

lgtm

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Feb 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, kkmsft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 68e8ae4 into Azure:master Feb 4, 2019
backlog automation moved this from In progress to Done Feb 4, 2019
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants