chore: per-agent pool k8s versions and provisioning state #423
Conversation
💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - |
|
…e calls. - Add per agentpool level kubernetes version and provisioning state. - Add calls to delete an entire vmss.
74ab9d8
to
f534b14
Compare
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 53.41% 53.39% -0.03%
==========================================
Files 95 95
Lines 14360 14433 +73
==========================================
+ Hits 7670 7706 +36
- Misses 6027 6061 +34
- Partials 663 666 +3 |
- Change to OrchestratorVersion from KubernetesVersion as per review comments. - Add couple of UTs.
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, kkmsft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Required work towards multi agentpool operations.
Issue Fixed:
These will start getting used by AKS multi agent pool work initially and then used in aks-engine multi agentpool operations - like delete, scale, upgrade.
Requirements:
Notes: