Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update cluster-autoscaler to 1.20.0 #4264

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR updates the cluster-autoscaler addon to 1.20.0. See:

https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.20.0

As this tested out O.K. with all currently supported versions of Kubernetes (1.17+), we can remove the heterogeneous set of supported cluster-autoscaler versions and pin to 1.20.0 for all versions of k8s.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Feb 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member Author

cc @mboersma

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #4264 (31a6fab) into master (1c12289) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4264   +/-   ##
=======================================
  Coverage   72.07%   72.07%           
=======================================
  Files         141      141           
  Lines       21686    21686           
=======================================
  Hits        15630    15630           
  Misses       5106     5106           
  Partials      950      950           
Impacted Files Coverage Δ
pkg/api/k8s_versions.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c12289...31a6fab. Read the comment docs.

@mboersma
Copy link
Member

mboersma commented Feb 12, 2021

pin to 1.20.0 for all versions of k8s.

I thought the idea was to keep cluster-autoscaler in sync with the Kubernetes minor version. That is, CA 1.20.x goes with Kubernetes 1.20.x (and 1.21.x until there's a specific release for it), CA 1.19.x goes with k8s 1.19.x, etc.

Also I see the Azure Pipeline for CA completed except for the publish step--I'll nudge upstream publishing to approve that.

@jackfrancis
Copy link
Member Author

@mboersma As far as our functional cluster-autoscaler tests go, 1.20 works w/ 1.17+, so that's good enough for me. I think until we can prove something doesn't work we shouldn't take on the additional test burden of validating version-to-version CA-k8s affinity. Having a single CA version simplifies our test matrix, and VHD maintenance.

cc @craiglpeters @devigned for any additional thoughts that may not agree with my conclusions above

@mboersma
Copy link
Member

I like the simplification of using one cluster-autoscaler--like AKS Engine does for core-dns--the tradeoff is we don't benefit from this upstream testing:

The below combinations have been tested on GCP. We don't do cross version testing or compatibility testing in other environments.

But I guess AKS Engine is doing cross-version testing, in the Azure environment, so I'm ok with that.

@jackfrancis jackfrancis merged commit f220f16 into Azure:master Feb 12, 2021
@jackfrancis jackfrancis deleted the cluster-autoscaler-1.20 branch February 12, 2021 21:45
@devigned
Copy link
Member

Late to the party. Sorry, this notification slipped past.

+1 to Matt's and Jack's comments and to our test matrix. Since we have cross version signal 1.20, we've done pretty well without taking on too much more test burden.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants