This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
refactor: Remove agentpool index usage from function which gets agent VM name #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmsft
requested review from
CecileRobertMichon,
tariq1890,
jackfrancis,
xizha162 and
yangl900
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=========================================
- Coverage 53.41% 53.4% -0.01%
=========================================
Files 95 95
Lines 14360 14360
=========================================
- Hits 7670 7669 -1
- Misses 6027 6028 +1
Partials 663 663 |
CecileRobertMichon
approved these changes
Feb 1, 2019
|
I'd prefer "refactor" over "fix" for the commit message since this isn't fixing any bugs |
kkmsft
force-pushed
the
remove-index-usage
branch
from
c029668
to
bc50bb0
Compare
|
@CecileRobertMichon - changed to refactor. |
CecileRobertMichon
changed the title
|
lgtm pending E2E and upgrade test |
|
LGTM too! Thanks KK! |
xizha162
approved these changes
Feb 2, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, kkmsft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Remove the agentpool index usage from upgrade code path.
Issue Fixed:
Remove agentpool index usage from function which gets agent VM name
Requirements:
Notes: