Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: use rbac.authorization.k8s.io/v1 for metrics-server #4367

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

rbac.authorization.k8s.io/v1beta1 is deprecated, and will be removed in the 1.22 release.

This PR uses the current rbac.authorization.k8s.io/v1 API version for metrics-server.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@acs-bot
Copy link

acs-bot commented Apr 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #4367 (9a4d1cd) into master (3445c1b) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4367      +/-   ##
==========================================
- Coverage   72.08%   72.04%   -0.04%     
==========================================
  Files         141      141              
  Lines       21667    21631      -36     
==========================================
- Hits        15618    15584      -34     
+ Misses       5097     5096       -1     
+ Partials      952      951       -1     
Impacted Files Coverage Δ
pkg/engine/templates_generated.go 43.31% <ø> (-0.25%) ⬇️
pkg/api/addons.go 98.01% <0.00%> (-0.03%) ⬇️
pkg/engine/artifacts.go 98.88% <0.00%> (-0.03%) ⬇️
pkg/api/k8s_versions.go 100.00% <0.00%> (ø)
pkg/api/vlabs/validate.go 81.83% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3445c1b...9a4d1cd. Read the comment docs.

@jackfrancis jackfrancis merged commit dee5a9a into Azure:master Apr 19, 2021
@jackfrancis jackfrancis deleted the metrics-server-rbac-api-version branch April 19, 2021 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants