This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: prevent race condition with docker/moby install #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,7 @@ removeEtcd() { | |||
| } | |||
|
|
|||
| removeMoby() { | |||
| sudo apt-get purge moby-engine moby-cli | |||
| sudo apt-get purge -y moby-engine moby-cli | |||
There was a problem hiding this comment.
forgot to commit this in #407, needed to avoid force purge without prompt
| @@ -165,6 +164,10 @@ echo `date`,`hostname`, endcustomscript>>/opt/m | |||
| mkdir -p /opt/azure/containers && touch /opt/azure/containers/provision.complete | |||
| ps auxfww > /opt/azure/provision-ps.log & | |||
|
|
|||
| if ! $FULL_INSTALL_REQUIRED; then | |||
| cleanUpContainerImages | |||
There was a problem hiding this comment.
moved this down to after container runtime is installed to avoid cleanup colliding with docker uninstall (if new version is needed)
|
lgtm |
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=======================================
Coverage 53.42% 53.42%
=======================================
Files 95 95
Lines 14385 14385
=======================================
Hits 7685 7685
Misses 6037 6037
Partials 663 663 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Cleaning up docker images in the background before installing docker can cause a race condition with docker install if we need to change the version of moby installed.
Issue Fixed:
Requirements:
Notes: