build: commit generated code files

[mboersma]

Reason for Change:

Keeping these generated files in the repository will help with vendoring and should make aks-engine "go get"-able. Since make build already calls make generate as a subtask, I don't think keeping them up to date will be onerous.

Issue Fixed:

Fixes #286

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tariq1890]

If we are doing this, we need to add a CI check to make sure the CI-runtime generated code doesn't differ from the committed generated code.

[mboersma]

need to add a CI check to make sure the CI-runtime generated code doesn't differ...

Good point--I'll work on adding that.

[mboersma]

/hold

[codecov]

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          95       95           
  Lines       14391    14391           
=======================================
  Hits         7690     7690           
  Misses       6038     6038           
  Partials      663      663

[tariq1890]

@CecileRobertMichon Is there a way to exclude the autogenerated files from the codecov check ?

[CecileRobertMichon]

@CecileRobertMichon Is there a way to exclude the autogenerated files from the codecov check ?

Yes, we can add any pkg we want skipped in https://github.com/Azure/aks-engine/blob/master/scripts/ginkgo.coverage.sh#L28-L29

[mboersma]

You can only skip entire packages with go cover tools, so I took the approach of giving the generated files a naming pattern and then stripping their results from the coverage file based on that. Seemed less disruptive than putting them in separate packages or working with +build flags.

Edit: nevermind, that didn't seem to work--codecov counted those files anyway. I added an ignore: directive to codecov.yml instead. This worked as expected--the codecov comment above shows "coverage will not change" now.

[mboersma]

/hold cancel