This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
ci: generate release notes for component versions installed in VHD build #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CecileRobertMichon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
=======================================
Coverage 63.84% 63.84%
=======================================
Files 91 91
Lines 14035 14035
=======================================
Hits 8961 8961
Misses 4396 4396
Partials 678 678 |
|
/AzurePipelines help |
|
/hold |
|
/AzurePipelines help |
|
/AzurePipelines run |
|
/azp run all |
1 similar comment
|
/azp run all |
CecileRobertMichon
force-pushed
the
vhd-release-notes
branch
from
1fd663d
to
7cf474f
Compare
CecileRobertMichon
changed the title
CecileRobertMichon
force-pushed
the
vhd-release-notes
branch
from
93fc179
to
5f675f2
Compare
CecileRobertMichon
changed the title
added 10 commits
March 4, 2019 10:26
CecileRobertMichon
force-pushed
the
vhd-release-notes
branch
from
09f1555
to
49ddce7
Compare
|
This is an example resulting file generated by this PR's VHD build: |
added 2 commits
March 4, 2019 16:33
tariq1890
reviewed
Mar 5, 2019
jackfrancis
reviewed
Mar 5, 2019
|
Made a suggestion. Feel free to ignore. lgtm if so |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Log which components are installed during the VHD script as part of the the VHD build pipeline to generate a text file of notes. For now, the file is published as an artifact of the pipeline and can be easily copy/pasted into a PR that adds the new image version. In the future, the goal is to automate adding the file to the the repo when the pipeline runs for publishing.
Side-fix:
set -o pipefailwhen running packer to make sure the Build VHD step fails if the script returns non-zero.Issue Fixed:
#427
Requirements:
Notes: