This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: configurable unattended-upgrades #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackfrancis
requested review from
mboersma,
devigned,
CecileRobertMichon,
Michael-Sinz and
jadarsie
Michael-Sinz
suggested changes
Aug 12, 2021
| @@ -650,6 +650,9 @@ func (a *Properties) validateLinuxProfile() error { | |||
| return errors.New("KeyData in LinuxProfile.SSH.PublicKeys cannot be empty string") | |||
| } | |||
| } | |||
| if a.LinuxProfile.EnableUnattendedUpgrades == nil { | |||
| log.Warnf("linuxProfile.enableUnattendedUpgrades configuration was not declared, your cluster nodes will be configured to run unattended-upgrade by default") | |||
There was a problem hiding this comment.
I would make the warning message scarier and add something about the impact, ie. this can lead to downtime if a bad patch is applied to all your nodes at once.
jadarsie
reviewed
Aug 16, 2021
jadarsie
approved these changes
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR introduces a boolean
"enableUnattendedUpgrades"configuration property to theLinuxProfileapi model configuration object. By default, we set it to true, preserving the existing behavior.We also log a warning if the user does not explicitly set this configuration, nudging her or him to do so next time.
If the
"enableUnattendedUpgrades"is set tofalse, then don't enable unattended-upgrades to run regularly in the background.Issue Fixed:
Related to #4595
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: