This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: upgrade will now recreate the correct master #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadarsie
reviewed
Aug 31, 2021
jadarsie
reviewed
Sep 1, 2021
jadarsie
approved these changes
Sep 2, 2021
|
Thanks for fixing this @deaborch! Confirmed that the current implementation indeed never does anything except to the first master: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Fix in Upgrade flow to recreate the correct missing master
Issue Fixed:
Fixes #4629
Problem occurs when the is a missing master in the upgrade process. The current implementation only recreates the first master at index (master-0) when there is a missing master node. This will cause upgrade to fail since the master it is trying to recreate already exists. This PR fixes that issue by finding the missing master and adding it to a map which will be checked and used to create the correct missing master at the correct index.
See steps to reproduce in the issue above.
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: