This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: resumeClusterAutoscaler nil dereference in rotate-certs #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only comment I have is that the user won't get feedback, I can try to do that. |
|
🎩 tip to @jadarsie |
jadarsie
approved these changes
Jan 19, 2022
|
@jackfrancis Do you happen to know when a new master binary will be built that incorporates this fix? Thank you! |
|
You can try this if you're using the aks-engine CLI on Linux amd64: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR addresses one nil pointer dereference opportunity in the rotate-certs flow.
Issue Fixed:
Related to #4810
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: