This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: Updating default Windows VHDs for to include 11B HNS fixes #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
marosset
force-pushed
the
new-windows-vhd-2212
branch
from
2530976
to
c723d62
Compare
jackfrancis
reviewed
Dec 15, 2022
| } | ||
|
|
||
| // WindowsServer2019OSImageConfig is the 'vanilla' Windows Server 2019 image | ||
| WindowsServer2019OSImageConfig = AzureOSImageConfig{ | ||
| ImageOffer: "WindowsServer", | ||
| ImageSku: "2019-Datacenter-Core-with-Containers-smalldisk", | ||
| ImagePublisher: "MicrosoftWindowsServer", | ||
| ImageVersion: "17763.3287.220806", | ||
| ImageVersion: "17763.3650.221105", |
There was a problem hiding this comment.
That VHD was published by the Windows team and was used the base for the aks-engine VHDs so it'll have a different publication timestamp.
Here's where we feed the image details into packer
aks-engine/vhd/packer/windows-2019-vars.json
Lines 1 to 7 in d22c979
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Rossetti marosset@microsoft.com
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: