This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: add "coming soon" regions to allow list #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @bridgetkromhout |
|
I don't see |
No, they are in the azure_locations.go file which is the actual gatekeeper. The other three locations required special handling since they aren’t (yet) visible via the API. Finally, the other three regions also had to be added to the test output (but not the two you mentioned) because that UT expects the command to list just the static or “special” locations. |
|
this should be ready to rebase and rerun tests |
mboersma
force-pushed
the
update-regions
branch
from
2f2b2b8
to
422f45a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adds some new and some "coming soon" regions to the list of allowed AKS engine locations:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
Requirements:
Notes: