chore: add support for k8s version 1.11.8 #615
Conversation
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 91 91
Lines 13905 13905
=======================================
Hits 7884 7884
Misses 5355 5355
Partials 666 666 |
packer/install-dependencies.sh
Outdated
@@ -95,7 +95,7 @@ for TILLER_VERSION in ${TILLER_VERSIONS}; do | |||
pullContainerImage "docker" "gcr.io/kubernetes-helm/tiller:v${TILLER_VERSION}" | |||
done | |||
|
|||
CLUSTER_AUTOSCALER_VERSIONS="1.13.1 1.12.2 1.3.4 1.3.3 1.2.2 1.1.2" | |||
CLUSTER_AUTOSCALER_VERSIONS="1.13.1 1.12.2 1.3.7 1.3.3 1.2.2 1.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's feel free to add component versions to VHD but retain old versions as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no references to cluster-autoscaler 1.3.4 any longer, so I dropped it from the VHD list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I guess 1.3.3 is also unused now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the removal--we need to audit AKS as well for usage before aging things out of the VHD image.
bb25e8c
to
d90444c
Compare
So we actually do want the cluster-autoscaler However, as we've already kicked off the VHD, what is the urgency of bumping cluster-autoscaler to 1.3.7 from 1.3.4? |
Here are the changes: kubernetes/autoscaler@cluster-autoscaler-1.3.4...cluster-autoscaler-1.3.7. This in particular looks desirable: kubernetes/autoscaler@fae2e71 |
d90444c
to
94c0f3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
lgtm pending E2E |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: add support for k8s version 1.11.8 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#changelog-since-v1117 * Update cluster-autoscaler to 1.3.7 for k8s 1.11.x See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#other-notable-changes and kubernetes/kubernetes#74136 * Add cluster-autoscaler 1.3.7 to VHD
* chore: add support for k8s version 1.11.8 See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#changelog-since-v1117 * Update cluster-autoscaler to 1.3.7 for k8s 1.11.x See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#other-notable-changes and kubernetes/kubernetes#74136 * Add cluster-autoscaler 1.3.7 to VHD
Reason for Change:
See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#changelog-since-v1117
Issue Fixed:
Requirements:
Notes: