Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update hybrid api model to "enableAutomaticUpdates": false #623

Merged

Conversation

jackfrancis
Copy link
Member

Reason for Change:

We want to default enableAutomaticUpdates to false for Windows agent pools. Updating the api model we use to run regular PR tests will give us some test signal as to any unintended side-effects of doing so.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   57.28%   57.28%           
=======================================
  Files          91       91           
  Lines       13947    13947           
=======================================
  Hits         7990     7990           
  Misses       5286     5286           
  Partials      671      671

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis added this to In progress in backlog Mar 4, 2019
@PatrickLang
Copy link
Contributor

/lgtm

@acs-bot
Copy link

acs-bot commented Mar 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit ab86de2 into Azure:master Mar 4, 2019
backlog automation moved this from In progress to Done Mar 4, 2019
@jackfrancis jackfrancis deleted the e2e-hybrid-diable-auto-updates branch March 4, 2019 23:36
juhacket pushed a commit to juhacket/aks-engine that referenced this pull request Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
backlog
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants