Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: rev the nvidia driver version for the newer driver #634

Merged
merged 1 commit into from Mar 4, 2019

Conversation

@welcome
Copy link

welcome bot commented Mar 4, 2019

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship
Make sure to check out the developer guide for guidance on testing your change.

@acs-bot acs-bot added the size/XS label Mar 4, 2019
@brendandburns
Copy link
Member Author

@acs-bot
Copy link

acs-bot commented Mar 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files          91       91           
  Lines       13947    13947           
=======================================
  Hits         8901     8901           
  Misses       4375     4375           
  Partials      671      671

@jackfrancis
Copy link
Member

@overplumbum @mathieu-benoit @brendandburns is this pre-existing E2E test scenario to validate cuda workloads that depend on this driver update?:

https://github.com/Azure/aks-engine/blob/master/test/e2e/kubernetes/workloads/cuda-vector-add.yaml

Basically we validate that the above workload is schedulable (requires an GPU-enabled/configured node) and finishes successfully to completion.

@CecileRobertMichon
Copy link
Contributor

/azp run AKS Engine VHD Pipeline

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@CecileRobertMichon
Copy link
Contributor

lgtm

Let's manually merge this when we're ready and update the squash commit message (single commit doesn't have chore: like title).

/hold

@jackfrancis jackfrancis added this to In progress in backlog Mar 4, 2019
@jackfrancis jackfrancis merged commit 14d4c84 into Azure:master Mar 4, 2019
backlog automation moved this from In progress to Done Mar 4, 2019
@welcome
Copy link

welcome bot commented Mar 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@jackfrancis
Copy link
Member

thanks @brendandburns!

@brendandburns brendandburns deleted the gpu branch March 4, 2019 21:26
tariq1890 pushed a commit to tariq1890/aks-engine that referenced this pull request Mar 5, 2019
@jackfrancis jackfrancis mentioned this pull request Mar 6, 2019
4 tasks
@tariq1890 tariq1890 moved this from TODO to Done in Go template refactor Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants