This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
test: increase e2e pod delete timeout tolerance to 5 mins #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run pr-e2e |
|
No pipelines are associated with this pull request. |
|
lgtm if e2e agrees |
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 63.89% 63.89%
=======================================
Files 91 91
Lines 14022 14022
=======================================
Hits 8960 8960
Misses 4385 4385
Partials 677 677 |
|
lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
danmassie
pushed a commit
to danmassie/aks-engine
that referenced
this pull request
Mar 9, 2019
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
We regularly see pod deletes succeeding just above the current timeout threshold of 1 minute. E.g.:
There is no strict reason to enforce a 1 minute timeout generally for all pod delete operations. Let's increase to 5 mins to account for normal operational variance.
Issue Fixed:
Requirements:
Notes: