Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for the terminationGracePeriodSeconds field #147

Closed
ErikMogensen opened this issue Sep 23, 2022 · 0 comments · Fixed by #148
Closed

Provide support for the terminationGracePeriodSeconds field #147

ErikMogensen opened this issue Sep 23, 2022 · 0 comments · Fixed by #148

Comments

@ErikMogensen
Copy link
Contributor

Proposal

I want to be able to set the terminationGracePeriodSeconds for the deployment resource.

Use-Case

I want it be able to set it above the default 30 seconds. For instance if a backend service takes three minutes to respond (a bit crazy but that happens) and the pod is sent a kill signal, responses may be lost. Therefore we want to be able to set it.

Also, to maintain compatibility with the yaml generated in the portal, which sets this value to 60.

Anything else?

I am able to provide a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant